APM convenience methods #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtursKadikis
requested changes
Jul 4, 2023
lib/countly.js
Outdated
| * This should be used to initialize the SDK with APM feature. It loads necessary scripts before initializing the SDK. | ||
| * @param {Object} conf - Countly config object. | ||
| */ | ||
| function initAfterAPM(conf) { |
examples/example_apm_async.html
Outdated
| Countly.url = "https://try.count.ly"; //your server goes here | ||
| Countly.debug = true; | ||
| Countly.apm = true; | ||
| // Countly.boomSRC = "../somewhere/boomerang.min.js"; |
There was a problem hiding this comment.
"boomSRC" -> "customSourceBoomerang"
examples/example_apm_async.html
Outdated
| Countly.debug = true; | ||
| Countly.apm = true; | ||
| // Countly.boomSRC = "../somewhere/boomerang.min.js"; | ||
| // Countly.clyBoomSRC = "../somewhere/countly_boomerang.js"; |
There was a problem hiding this comment.
"clyBoomSRC" -> "customSourceCountlyBoomerang"
examples/example_apm_async.html
Outdated
| Countly.app_key = "YOUR_APP_KEY"; | ||
| Countly.url = "https://try.count.ly"; //your server goes here | ||
| Countly.debug = true; | ||
| Countly.apm = true; |
There was a problem hiding this comment.
"apm" -> "loadAPMScriptsAsync"
lib/countly.js
Outdated
| @@ -180,6 +188,7 @@ | |||
| var SDK_NAME = "javascript_native_web"; | |||
|
|
|||
| var urlParseRE = /^(((([^:\/#\?]+:)?(?:(\/\/)((?:(([^:@\/#\?]+)(?:\:([^:@\/#\?]+))?)@)?(([^:\/#\?\]\[]+|\[[^\/\]@#?]+\])(?:\:([0-9]+))?))?)?)?((\/?(?:[^\/\?#]+\/+)*)([^\?#]*)))?(\?[^#]+)?)(#.*)?/; | |||
| var shouldLetApmLoading = true; // used to prevent loading apm scripts multiple times. | |||
There was a problem hiding this comment.
"shouldLetApmLoading" -> "apmLibrariesAlreadyLoaded"
ArtursKadikis
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.